Re: [PATCH 1/1] regulator: fixed: add system pm routines for pinctrl
From: Peter Chen
Date: Thu Mar 12 2020 - 11:03:31 EST
On 20-03-12 14:37:23, Mark Brown wrote:
> On Thu, Mar 12, 2020 at 01:00:33PM +0000, Peter Chen wrote:
> > On 20-03-12 11:47:12, Mark Brown wrote:
>
> > > Which pins exactly is this controlling? I would not expect a fixed
> > > voltage regulator to have pinctrl support, this feels like it's papering
> > > over some other issue.
>
> > Sorry, I forget sending dts patch. We use fixed gpio regulator to control
> > USB VBus.
>
> Surely it's the GPIO controller that needs pinctrl support then?
But the pinctrl register value for this gpio will be cleared after
suspend, we need to restore it, otherwise, the function will be not
gpio. See below patch: