Re: [PATCH] gpio: thunderx: fix irq_request_resources
From: Tim Harvey
Date: Thu Mar 12 2020 - 13:16:56 EST
On Thu, Mar 12, 2020 at 6:42 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Wed, Mar 11, 2020 at 4:43 PM Tim Harvey <tharvey@xxxxxxxxxxxxx> wrote:
>
> > If there are no parent resources do not call irq_chip_request_resources_parent
> > at all as this will return an error.
> >
> > This resolves a regression where devices using a thunderx gpio as an interrupt
> > would fail probing.
> >
> > Fixes: 0d04d0c ("gpio: thunderx: Use the default parent apis for {request,release}_resources")
> > Signed-off-by: Tim Harvey <tharvey@xxxxxxxxxxxxx>
>
> This patch does not apply to the mainline kernel or v5.6-rc1.
>
> Please verify:
> 1. If the problem is still in v5.6 (we refactored the driver to
> use GPIOLIB_IRQCHIP)
Linus,
Sorry, another issue was keeping me from being able to boot 5.6-rc but
that's now understood and I can confirm the issue is not present in
v5.6-rc5
>
> 2. If not, only propose it for linux-stable v5.5 etc.
>
Yes, needs to be applied to v5.2, v5.3, v5.4, v5.5. I cc'd stable. If
I need to re-submit please let me know.
Cc: stable@xxxxxxxxxxxxxxx
Tim