Re: [PATCH net-next v2 14/15] ethtool: set device channel counts with CHANNELS_SET request

[Jakub Kicinski]

On Thu, 12 Mar 2020 21:08:43 +0100 (CET) Michal Kubecek wrote:
> Implement CHANNELS_SET netlink request to set channel counts of a network
> device. These are traditionally set with ETHTOOL_SCHANNELS ioctl request.
> 
> Like the ioctl implementation, the generic ethtool code checks if supplied
> values do not exceed driver defined limits; if they do, first offending
> attribute is reported using extack. Checks preventing removing channels
> used for RX indirection table or zerocopy AF_XDP socket are also
> implemented.
> 
> Move ethtool_get_max_rxfh_channel() helper into common.c so that it can be
> used by both ioctl and netlink code.
> 
> v2:
>   - fix netdev reference leak in error path (found by Jakub Kicinsky)
> 
> Signed-off-by: Michal Kubecek <mkubecek@xxxxxxx>

Reviewed-by: Jakub Kicinski <kuba@xxxxxxxxxx>

Thanks!