Re: [PATCH for-5.7/drivers v2 1/1] null_blk: describe the usage of fault injection param

[Chaitanya Kulkarni]

NVMe does have the same format in host/fault_inject.c.

This description matches what we have in :-

null_setup_fault
	__null_setup_fault()
		setup_fault_attr()

looks good to me.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>

On 03/12/2020 03:01 PM, Dongli Zhang wrote:
> As null_blk is a very good start point to test block layer, this patch
> adds description and comments to 'timeout', 'requeue' and 'init_hctx' to
> explain how to use fault injection with null_blk.
>
> The nvme has similar with nvme_core.fail_request in the form of comment.
>
> Signed-off-by: Dongli Zhang<dongli.zhang@xxxxxxxxxx>