Re: [PATCH net-next v2 2/3] net: phy: mscc: split the driver into separate files

[David Miller]

From: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>
Date: Thu, 12 Mar 2020 23:10:32 +0100

> +inline int vsc8584_macsec_init(struct phy_device *phydev)
> +{
> +	return 0;
> +}
> +inline void vsc8584_handle_macsec_interrupt(struct phy_device *phydev)
> +{
> +}
> +inline void vsc8584_config_macsec_intr(struct phy_device *phydev)
> +{
> +}

Please use "static inline", as otherwise if this file is included multiple times it
will cause the compiler to emit potentially two uninlined copies which will result
in a linking error.