Re: [PATCH] checkpatch: always allow C99 SPDX License Identifer comments

[Scott Branden]

Hi Joe,

On 2020-03-11 9:42 p.m., Joe Perches wrote:
> On Wed, 2020-03-11 at 19:48 -0700, Scott Branden wrote:
> > Hi Joe,
> >
> > On 2020-03-11 7:26 p.m., Joe Perches wrote:
> > > On Wed, 2020-03-11 at 12:11 -0700, Scott Branden wrote:
> > > > Always allow C99 comment styles if SPDK-License-Identifier is in comment
> > > > even if C99_COMMENT_TOLERANCE is specified in the --ignore options.
> > > Why is this useful?
> > This is useful because if you run checkpatch with
> > --ignore=C99_COMMENT_TOLERANCE
> > right now it will warn on almost every .c file in the linux kernel due
> > to the decision to
> > use // SPDX-License-Identifier: at the start of every c file
> Maybe this is better:
>
> Just don't perform any other per-line checks on a valid or invalid
> SPDX line.
I tried your change and it works as well.
Probably better/simpler if no other processing is needed on lines with 
SPDX-License-Indentifier: on it.

Would you like to just submit your patch or do I need to construct 
something?
> ---
>   scripts/checkpatch.pl | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 529c892..3f2ae7 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3171,6 +3171,7 @@ sub process {
>   						WARN("SPDX_LICENSE_TAG",
>   						     "'$spdx_license' is not supported in LICENSES/...\n" . $herecurr);
>   					}
> +					next;
>   				}
>   			}
>   		}