Re: [PATCH] irqchip/gic-v4: Fix non-stick page size error for setup GITS_BASER

From: Marc Zyngier
Date: Fri Mar 13 2020 - 08:35:14 EST


On 2020-03-13 12:00, Marc Zyngier wrote:

[...]

The astute reader will have noticed that I've sent the wrong patch:

+static int its_probe_baser_psz(struct its_node *its, struct its_baser *baser)
+{
+ u64 psz = SZ_64K;
+
+ while (psz) {
+ u64 val, gpsz;
+
+ val = its_read_baser(its, baser);
+ val &= ~GITS_BASER_PAGE_SIZE_MASK;
+
+ switch (psz) {
+ case SZ_64K:
+ gpsz = GITS_BASER_PAGE_SIZE_64K;
+ break;
+ case SZ_16K:
+ gpsz = GITS_BASER_PAGE_SIZE_16K;
+ break;
+ case SZ_4K:
+ default:
+ gpsz = GITS_BASER_PAGE_SIZE_4K;
+ break;
+ }
+
+ gpz >>= GITS_BASER_PAGE_SIZE_SHIFT;

s/gpz/gpsz/

Sorry for the noise,

M.
--
Jazz is not dead. It just smells funny...