Re: [PATCH v3] unicore32: replace setup_irq() by request_irq()
From: afzal mohammed
Date: Fri Mar 13 2020 - 08:45:27 EST
Hi Guan Xuetao,
On Wed, Mar 04, 2020 at 06:21:37AM +0530, afzal mohammed wrote:
> request_irq() is preferred over setup_irq(). Invocations of setup_irq()
> occur after memory allocators are ready.
>
> Per tglx[1], setup_irq() existed in olden days when allocators were not
> ready by the time early interrupts were initialized.
>
> Hence replace setup_irq() by request_irq().
>
> [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@xxxxxxxxx>
> ---
> Hi unicorn maintainers,
>
> if okay w/ this change, please consider taking it thr' your tree, else please
> let me know.
i have not seen any recent pull request from you for unicore32, if
this patch is okay, please consider ack-ing this so as to take via
tglx.
Regards
afzal