Re: [RESEND PATCH 2/5] phy: sun4i-usb: add support for the USB PHY on suniv SoC

[George Hilliard]

On Thu, Mar 12, 2020, 11:08 PM Chen-Yu Tsai <wens@xxxxxxxx> wrote:
>
> On Thu, Mar 12, 2020 at 8:06 PM George Hilliard
> <thirtythreeforty@xxxxxxxxx> wrote:
> >
> > Thanks for the review.
> >
> > On Thu, Mar 12, 2020 at 1:51 AM Chen-Yu Tsai <wens@xxxxxxxx> wrote:
> > >
> > > On Tue, Mar 10, 2020 at 4:43 AM George Hilliard
> > > <thirtythreeforty@xxxxxxxxx> wrote:
> > > >
> > > > The suniv SoC has one USB OTG port connected to a MUSB controller.
> > > >
> > > > Add support for its USB PHY.
> > > >
> > > > Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx>
> > >
> > > Not sure why Icenowy's SoB is here. If she was the original author, you
> > > are supposed to keep her name as the author.
> >
> > So, I was unclear on the convention here.  This patch is based on her
> > patch, but I've modified it and rebased those modifications back into
> > a single change.  I'm happy to change the author field - does it need
> > a "Co-authored-by: myself" here?
>
> I suppose that really depends on how much you changed it. If it were just
> stylistic changes I'd keep the original author. Also you should list any
> changes you made to the patch by inserting
>
>     [<who>: changed foo and bar]
>
> before your SoB.

Ok, this makes sense. Thanks. I'll send another series. The few that
are stylistic, I believe I retained Icenowy as the author. Where I
modified them, I put myself (so people email me, not her, with
problems).  I'll modify the commit messages like you describe and
double check the authorship.

> As for the Co-authored-by, I haven't really seen it used so I don't really
> know.

Off topic, but I wish Git supported multiple authors natively.

George