Re: [PATCH v4 1/4] dt-bindings: net: phy: Add support for NXP TJA11xx

[Florian Fainelli]

On 3/12/2020 10:22 PM, Oleksij Rempel wrote:
> Document the NXP TJA11xx PHY bindings.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/net/nxp,tja11xx.yaml  | 61 +++++++++++++++++++
>  1 file changed, 61 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
> new file mode 100644
> index 000000000000..42be0255512b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: GPL-2.0+
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/nxp,tja11xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP TJA11xx PHY
> +
> +maintainers:
> +  - Andrew Lunn <andrew@xxxxxxx>
> +  - Florian Fainelli <f.fainelli@xxxxxxxxx>
> +  - Heiner Kallweit <hkallweit1@xxxxxxxxx>
> +
> +description:
> +  Bindings for NXP TJA11xx automotive PHYs
> +
> +allOf:
> +  - $ref: ethernet-phy.yaml#
> +
> +patternProperties:
> +  "^ethernet-phy@[0-9a-f]+$":
> +    type: object
> +    description: |
> +      Some packages have multiple PHYs. Secondary PHY should be defines as
> +      subnode of the first (parent) PHY.


There are QSGMII PHYs which have 4 PHYs embedded and AFAICT they are
defined as 4 separate Ethernet PHY nodes and this would not be quite a
big stretch to represent them that way compared to how they are.

I would recommend doing the same thing and not bend the MDIO framework
to support the registration of "nested" Ethernet PHY nodes.
-- 
Florian