Re: [PATCH] timer: silenct a lockdep splat with debugobjects

From: Qian Cai
Date: Fri Mar 13 2020 - 22:53:29 EST




> On Mar 13, 2020, at 5:26 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> On Fri, Mar 13, 2020 at 05:00:41PM -0400, Qian Cai wrote:
>>> On Mar 13, 2020, at 4:13 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
>>>
>>> Or, fix that random crud to do the wakeup outside of the lock.
>>
>> That is likely to be difficult until we can find a creative way to not âuglifying" the
>> random code by dropping locks in the middle etc just because of debugojects.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/log/?h=random/fast
>
> Doesn't look difficult at all.

Great. I cherry-picked the first two patches,

random: Consolidate entropy batches for u32 and u64
random: Remove batched entropy locking

which solved the issue here as well.

Andy, may I ask what your plan to post those?