Re: [PATCH RFC 3/3] speakup: misc: Use dynamic minor numbers for speakup devices

[Samuel Thibault]

Hello,

Greg KH, le lun. 09 mars 2020 08:15:06 +0100, a ecrit:
> On Mon, Mar 09, 2020 at 10:17:47AM +0800, Zhenzhong Duan wrote:
> > Arnd notes in the link:
> >    | To clarify: the only numbers that I think should be changed to dynamic
> >    | allocation are for drivers/staging/speakup. While this is a fairly old
> >    | subsystem, I would expect that it being staging means we can be a
> >    | little more progressive with the changes.
> > 
> > This releases misc device minor numbers 25-27 for dynamic usage.
> > 
> > Link: https://lore.kernel.org/lkml/20200120221323.GJ15860@xxxxxxx/t/
> > Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxx>

Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

> > Cc: William Hubbs <w.d.hubbs@xxxxxxxxx>
> > Cc: Chris Brannon <chris@xxxxxxxxxxxxxxxx>
> > Cc: Kirk Reiser <kirk@xxxxxxxxxx>
> > Cc: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > ---
> >  drivers/staging/speakup/devsynth.c     | 10 +++-------
> >  drivers/staging/speakup/speakup_soft.c | 14 +++++++-------
> >  2 files changed, 10 insertions(+), 14 deletions(-)
> 
> speakup, while being in staging, has been around for a very long time,
> so we might break things if we change their minor numbers.
> 
> I'd need an ACK from the speakup maintainers/developers before I can
> take this as I don't have any way to verify what their systems look
> like.

I believe it will be fine to use dynamic minor numbers, since the /dev
entries are autocreated nowadays, and the espeakup and speechd-up don't
use hardcoded minor values.

Thanks for making sure,
Samuel