Re: [PATCH net-next] chcr: remove set but not used variable 'status'

[rohit maheshwari]

On 14/03/20 4:21 PM, YueHaibing wrote:
> drivers/crypto/chelsio/chcr_ktls.c: In function chcr_ktls_cpl_set_tcb_rpl:
> drivers/crypto/chelsio/chcr_ktls.c:662:11: warning:
>   variable status set but not used [-Wunused-but-set-variable]
>
> commit 8a30923e1598 ("cxgb4/chcr: Save tx keys and handle HW response")
> involved this unused variable, remove it.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
>   drivers/crypto/chelsio/chcr_ktls.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/chelsio/chcr_ktls.c b/drivers/crypto/chelsio/chcr_ktls.c
> index f0c3834eda4f..00099e793e63 100644
> --- a/drivers/crypto/chelsio/chcr_ktls.c
> +++ b/drivers/crypto/chelsio/chcr_ktls.c
> @@ -659,10 +659,9 @@ int chcr_ktls_cpl_set_tcb_rpl(struct adapter *adap, unsigned char *input)
>   	const struct cpl_set_tcb_rpl *p = (void *)input;
>   	struct chcr_ktls_info *tx_info = NULL;
>   	struct tid_info *t;
> -	u32 tid, status;
> +	u32 tid;
>   
>   	tid = GET_TID(p);
> -	status = p->status;
>   
>   	t = &adap->tids;
>   	tx_info = lookup_tid(t, tid);

Thanks for fixing it. Looks good to me.