Re: [PATCH v4 2/2] pinctrl: make MediaTek MT6765 pinctrl ready for buidling loadable module

[Sean Wang]

Hi, Light

On Tue, Mar 10, 2020 at 12:39 AM <light.hsieh@xxxxxxxxxxxx> wrote:
>
> From: Light Hsieh <light.hsieh@xxxxxxxxxxxx>
>
> This patch make pinctrl-mt6765 ready for building as loadable module.
s/building/building/

I got build error after when those two patches are being applied
../drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:529:1: error:
'mtk_pinconf_bias_set_gev1' undeclared here (not in a function)

>
> Signed-off-by: Light Hsieh <light.hsieh@xxxxxxxxxxxx>
> Reviewed-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> ---
>  drivers/pinctrl/mediatek/Kconfig          | 2 +-
>  drivers/pinctrl/mediatek/pinctrl-mt6765.c | 4 ++++
>  2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
> index 4cd1109..c645fdb 100644
> --- a/drivers/pinctrl/mediatek/Kconfig
> +++ b/drivers/pinctrl/mediatek/Kconfig
> @@ -89,7 +89,7 @@ config PINCTRL_MT2712
>         select PINCTRL_MTK
>
>  config PINCTRL_MT6765
> -       bool "Mediatek MT6765 pin control"
> +       tristate "Mediatek MT6765 pin control"
>         depends on OF
>         depends on ARM64 || COMPILE_TEST
>         default ARM64 && ARCH_MEDIATEK
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mt6765.c b/drivers/pinctrl/mediatek/pinctrl-mt6765.c
> index 905dae8c..2c59d39 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mt6765.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mt6765.c
> @@ -6,6 +6,7 @@
>   *
>   */
>
> +#include <linux/module.h>
>  #include "pinctrl-mtk-mt6765.h"
>  #include "pinctrl-paris.h"
>
> @@ -1103,3 +1104,6 @@ static int __init mt6765_pinctrl_init(void)
>         return platform_driver_register(&mt6765_pinctrl_driver);
>  }
>  arch_initcall(mt6765_pinctrl_init);
> +
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("MediaTek MT6765 Pinctrl Driver");
> --
> 1.8.1.1.dirty