Re: [PATCH] Revert "x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T"

[Jian-Hong Pan]

Borislav Petkov <bp@xxxxxxxxx> æ 2020å3æ12æ éå äå6:46åéï
>
> On Thu, Mar 12, 2020 at 04:33:42PM +0800, Jian-Hong Pan wrote:
> > This reverts commit 0082517fa4bce073e7cf542633439f26538a14cc.
> >
> > According to Acer's information, this reboot issue is fixed since 1.08
> > and newer BIOS. So, we can revert the quirk.
>
> We can?
>
> How do you know *everyone* affected will update their BIOS?
>
> And what's the downside of keeping it?

Good question!
How about add DMI_BIOS_VERSION for BIOS DMI_MATCH.  For example,
DMI_MATCH(DMI_BIOS_VERSION, "V1.0")

The BIOS versions listed on Acer website [1] are 1.04, 1.10 ...
The reboot issue is fixed since BIOS 1.08.  So, the only the string
like "V1.0*" should apply the quirk.

But, that will raise another question:  Since the original quirk works
for all Acer X514-51T and the quirk cannot be removed for older BIOS.
Why not keep only original matching items for all Acer X514-51T
laptops?

I am not sure which option is better.  Any comment?

[1] https://www.acer.com/ac/en/US/content/support-product/7889?b=1

BR,
Jian-Hong Pan