Re: [PATCH v3] powerpc/fsl-85xx: fix compile error

[Michael Ellerman]

WANG Wenhu <wenhu.wang@xxxxxxxx> writes:
> Include "linux/of_address.h" to fix the compile error for
> mpc85xx_l2ctlr_of_probe() when compiling fsl_85xx_cache_sram.c.
>
>   CC      arch/powerpc/sysdev/fsl_85xx_l2ctlr.o
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c: In function âmpc85xx_l2ctlr_of_probeâ:
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:11: error: implicit declaration of function âof_iomapâ; did you mean âpci_iomapâ? [-Werror=implicit-function-declaration]
>   l2ctlr = of_iomap(dev->dev.of_node, 0);
>            ^~~~~~~~
>            pci_iomap
> arch/powerpc/sysdev/fsl_85xx_l2ctlr.c:90:9: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
>   l2ctlr = of_iomap(dev->dev.of_node, 0);
>          ^
> cc1: all warnings being treated as errors
> scripts/Makefile.build:267: recipe for target 'arch/powerpc/sysdev/fsl_85xx_l2ctlr.o' failed
> make[2]: *** [arch/powerpc/sysdev/fsl_85xx_l2ctlr.o] Error 1
>
> Fixes: commit 6db92cc9d07d ("powerpc/85xx: add cache-sram support")

The syntax is:

Fixes: 6db92cc9d07d ("powerpc/85xx: add cache-sram support")

> Cc: stable <stable@xxxxxxxxxxxxxxx>

The commit above went into v2.6.37.

So no one has noticed this bug since then, how? Or did something else
change to expose the problem?

cheers