RE: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col parameter

[Sherry Sun]

Hi Borislav,

> -----Original Message-----
> From: Borislav Petkov <bp@xxxxxxxxx>
> Sent: 2020å3æ16æ 18:44
> To: Sherry Sun <sherry.sun@xxxxxxx>
> Cc: mchehab@xxxxxxxxxx; tony.luck@xxxxxxxxx; james.morse@xxxxxxx;
> rrichter@xxxxxxxxxxx; michal.simek@xxxxxxxxxx; manish.narani@xxxxxxxxxx;
> linux-edac@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>; Frank Li <frank.li@xxxxxxx>
> Subject: Re: [PATCH v2] EDAC: synopsys: Fix the wrong call of pinf->col
> parameter
> 
> On Mon, Mar 16, 2020 at 01:30:39AM +0000, Sherry Sun wrote:
> > Maybe you misunderstood the handle_error(), this function has already
> > distinguished between Zynq and ZynqMP through priv->p_data->quirks.
> > And what I am doing in this patch is to remove the useless pinf->col
> > in ZynqMP part, which won't break the Zynq part.
> 
> Ok, I see it now, thanks for clarifying.
> 
> Now, in your v2 pls fix this check in handle_error():
> 
> 	if (!priv->p_data->quirks) {
> 
> to *actually* *explicitly* check that the platform for which this function is
> called, really supports interrupts, i.e., DDR_ECC_INTR_SUPPORT, and not that
> the ->quirks thing is != 0. Like the rest of the code does.
> 

Ok, I will fix this check.

Best regards
Sherry Sun

> Thx.
> 
> --
> Regards/Gruss,
>     Boris.
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeopl
> e.kernel.org%2Ftglx%2Fnotes-about-
> netiquette&amp;data=02%7C01%7Csherry.sun%40nxp.com%7Ccd843239ffd
> d48a05ce408d7c996ebd5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C
> 0%7C637199522356909838&amp;sdata=5p6JuXQQJgyjlaMOUH1cLLSDFbUzM
> R%2Fjzs5HC%2FeU1Zc%3D&amp;reserved=0