Re: [PATCH] Makefile: disallow data races on gcc-10 as well

[Jiri Kosina]

On Tue, 17 Mar 2020, Jiri Kosina wrote:

> > The flag change happened at https://gcc.gnu.org/PR92046.
> > 
> > CC: Jiri Kosina <jkosina@xxxxxxx>
> > CC: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> > CC: Michal Marek <michal.lkml@xxxxxxxxxxx>
> > CC: linux-kbuild@xxxxxxxxxxxxxxx
> > Signed-off-by: Sergei Trofimovich <slyfox@xxxxxxxxxx>
> > ---
> >  Makefile | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Makefile b/Makefile
> > index 171f2b004c8a..9696eb2cd5a1 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -714,6 +714,7 @@ endif
> >  
> >  # Tell gcc to never replace conditional load with a non-conditional one
> >  KBUILD_CFLAGS	+= $(call cc-option,--param=allow-store-data-races=0)
> > +KBUILD_CFLAGS	+= $(call cc-option,-fno-allow-store-data-races)
> 
> I have to say I can't really read gcc sources without major cerebral pain, 
> so let me me dense here: what happens to gcc<10 if you pass 
> -fno-allow-store-data-races to it?

Sorry, brainfart on my side, your patch is good :)

	Acked-by: Jiri Kosina <jkosina@xxxxxxx>

Thanks,

-- 
Jiri Kosina
SUSE Labs