Re: [PATCH v5 1/5] gpiolib: Add support for gpiochipN-based table lookup
From: Geert Uytterhoeven
Date: Tue Mar 17 2020 - 04:42:02 EST
Hi Linus,
On Thu, Mar 12, 2020 at 3:23 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Tue, Feb 18, 2020 at 4:18 PM Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx> wrote:
>
> > Currently GPIO controllers can only be referred to by label in GPIO
> > lookup tables.
> >
> > Add support for looking them up by "gpiochipN" name, with "N" the
> > corresponding GPIO device's ID number.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Reviewed-by: Ulrich Hecht <uli+renesas@xxxxxxxx>
> > Reviewed-by: Eugeniu Rosca <erosca@xxxxxxxxxxxxxx>
> > Tested-by: Eugeniu Rosca <erosca@xxxxxxxxxxxxxx>
>
> Just like with patch 2/5 I have the same problem here that
> the commit message doesn't state the technical reason why
> we need to change this and support the device name in these
> tables and not just labels.
As these "gpiochipN" names are not stable, I will drop this patch, and
the related support.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds