Re: [PATCH v5 00/13] SCMI Notifications Core Support

From: Lukasz Luba
Date: Wed Mar 18 2020 - 05:02:00 EST


Hi Cristian,

On 3/16/20 3:03 PM, Cristian Marussi wrote:
Hi all,

this series wants to introduce SCMI Notification Support, built on top of
the standard Kernel notification chain subsystem.

At initialization time each SCMI Protocol takes care to register with the
new SCMI notification core the set of its own events which it intends to
support.

Using the API exposed via scmi_handle.notify_ops a Kernel user can register
its own notifier_t callback (via a notifier_block as usual) against any
registered event as identified by the tuple:

(proto_id, event_id, src_id)

where src_id represents a generic source identifier which is protocol
dependent like domain_id, performance_id, sensor_id and so forth.
(users can anyway do NOT provide any src_id, and subscribe instead to ALL
the existing (if any) src_id sources for that proto_id/evt_id combination)

Each of the above tuple-specified event will be served on its own dedicated
blocking notification chain, dynamically allocated on-demand when at least
one user has shown interest on that event.

Upon a notification delivery all the users' registered notifier_t callbacks
will be in turn invoked and fed with the event_id as @action param and a
generated custom per-event struct _report as @data param.
(as in include/linux/scmi_protocol.h)

The final step of notification delivery via users' callback invocation is
instead delegated to a pool of deferred workers (Kernel cmwq): each
SCMI protocol has its own dedicated worker and dedicated queue to push
events from the rx ISR to the worker.


Could you give an example how the notification would be delivered
further to the upper layers, like hwmon driver, cpufreq or thermal?
For example, for sensor protocol which delivers event
SENSOR_TRIP_POINT_EVENT indicating a trip point was crossed.

Would it be possible for:
drivers/hwmon/scmi-hwmon.c
to get this temperature events like an interrupt?

I couldn't find it in the implementation of the registered handlers.

Regards,
Lukasz