Re: Re: [PATCH] arm64: add blank after 'if'
From: Catalin Marinas
Date: Wed Mar 18 2020 - 05:30:47 EST
On Wed, Mar 18, 2020 at 01:32:28PM +0800, çæè wrote:
> From: Will Deacon <will@xxxxxxxxxx>
> Date: 2020-03-18 06:28:24
> To: Zheng Wei <wei.zheng@xxxxxxxx>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>,Hanjun Guo <guohanjun@xxxxxxxxxx>,Enrico Weigelt <info@xxxxxxxxx>,Allison Randal <allison@xxxxxxxxxxx>,Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>,Thomas Gleixner <tglx@xxxxxxxxxxxxx>,Yunfeng Ye <yeyunfeng@xxxxxxxxxx>,linux-arm-kernel@xxxxxxxxxxxxxxxxxxx,linux-kernel@xxxxxxxxxxxxxxx,kernel@xxxxxxxx,wenhu.wang@xxxxxxxx
> Subject: Re: [PATCH] arm64: add blank after 'if'>On Fri, Mar 13, 2020 at 10:54:02PM +0800, Zheng Wei wrote:
> >> add blank after 'if' for armv8_deprecated_init()
> >> to make it comply with kernel coding style.
> >>
> >> Signed-off-by: Zheng Wei <wei.zheng@xxxxxxxx>
> >> ---
> >> arch/arm64/kernel/armv8_deprecated.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/kernel/armv8_deprecated.c b/arch/arm64/kernel/armv8_deprecated.c
> >> index 7832b3216370..4cc581af2d96 100644
> >> --- a/arch/arm64/kernel/armv8_deprecated.c
> >> +++ b/arch/arm64/kernel/armv8_deprecated.c
> >> @@ -630,7 +630,7 @@ static int __init armv8_deprecated_init(void)
> >> register_insn_emulation(&cp15_barrier_ops);
> >>
> >> if (IS_ENABLED(CONFIG_SETEND_EMULATION)) {
> >> - if(system_supports_mixed_endian_el0())
> >> + if (system_supports_mixed_endian_el0())
> >> register_insn_emulation(&setend_ops);
> >> else
> >> pr_info("setend instruction emulation is not supported on this system\n");
> >
> >(Catalin: I'm just acking these trivial typo/style fixes to get them out
> >of my inbox; do whatever you like with them ;)
> >
> >Acked-by: Will Deacon <will@xxxxxxxxxx>
> >
> >Will
>
> Shouldn't you have Cc trivial<trivial@xxxxxxxxxx>?
> Asked-by: Wang Wenhu <wenhu.wang@xxxxxxxx>
I queued them already, they are in arm64 for-next/core. In the future,
it they could as well go in via trivial@xxxxxxxxxx (as long as there are
no serious conflicts).
--
Catalin