Re: [PATCH 1/2] ASoC: qcom: sdm845: handle soundwire stream

[Pierre-Louis Bossart]

On 3/18/20 10:57 AM, Srinivas Kandagatla wrote:
> On 18/03/2020 15:26, Pierre-Louis Bossart wrote:
> > Same comment, how does the notion of cpu_dai come in the picture for a 
> > SoundWire dailink?
> > Would you mind listing what the components of the dailinks are?
>
> dais that I was referring here are all codec dais from backend-dai.
>
> Device tree entries from
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/sdm845-db845c.dts?h=next-20200318#n538 
>
>
>
> Frontend-dai:
>  ÂÂÂÂmm1-dai-link {
>  ÂÂÂÂÂÂÂ link-name = "MultiMedia1";
>  ÂÂÂÂÂÂÂ cpu {
>   sound-dai = <&q6asmdai MSM_FRONTEND_DAI_MULTIMEDIA1>;
>  ÂÂÂÂÂÂÂ };
>  ÂÂÂÂ};
>
> Backend-dai:
>  ÂÂÂÂslim-dai-link {
>  ÂÂÂÂÂÂÂ link-name = "SLIM Playback";
>  ÂÂÂÂÂÂÂ cpu {
>  ÂÂÂÂÂÂÂÂÂÂÂ sound-dai = <&q6afedai SLIMBUS_0_RX>;
>  ÂÂÂÂÂÂÂ };
>
>  ÂÂÂÂÂÂÂ platform {
>  ÂÂÂÂÂÂÂÂÂÂÂ sound-dai = <&q6routing>;
>  ÂÂÂÂÂÂÂ };
>
>  ÂÂÂÂÂÂÂ codec {
>  ÂÂÂÂÂÂÂÂÂÂÂ sound-dai =Â <&left_spkr>, <&right_spkr>, <&swm 0>, 
> <&wcd9340 0>;
>  ÂÂÂÂÂÂÂ };

Thanks, I didn't realize this and now understand your point.

I guess that means we've officially stretched the limits of the DPCM 
model though, lumping all codec dais from separate devices into the same 
'backend' doesn't seem like a very good path forward, we'd really need a 
notion of domain to represent such bridges.

For now for the series

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>