Re: [PATCH] xen-pciback: fix INTERRUPT_TYPE_* defines

[Boris Ostrovsky]

On 3/19/20 12:06 AM, Marek Marczykowski-GÃrecki wrote:
> INTERRUPT_TYPE_NONE should be 0,


Would

 return ret ?: INTERRUPT_TYPE_NONE

in xen_pcibk_get_interrupt_type() work?


I think it's better not to tie macro name to a particular value.


-boris


>   as it is assumed in
> xen_pcibk_get_interrupt_type(). Fix the definition, and also shift other
> values to not leave holes.
> But also use INTERRUPT_TYPE_NONE in xen_pcibk_get_interrupt_type() to
> avoid similar confusions in the future.
>
> Fixes: 476878e4b2be ("xen-pciback: optionally allow interrupt enable flag writes")
> Signed-off-by: Marek Marczykowski-GÃrecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>
>