Re: [PATCH v2 2/2] mm/page_alloc: integrate classzone_idx and high_zoneidx

[Joonsoo Kim]

2020ë 3ì 19ì (ë) ìí 9:32, Vlastimil Babka <vbabka@xxxxxxx>ëì ìì:
>
> On 3/18/20 4:32 AM, js1304@xxxxxxxxx wrote:
> > From: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
> >
> > classzone_idx is just different name for high_zoneidx now.
> > So, integrate them and add some comment to struct alloc_context
> > in order to reduce future confusion about the meaning of this variable.
> >
> > In addition to integration, this patch also renames high_zoneidx
> > to highest_zoneidx since it represents more precise meaning.
>
> 2 years ago I suggested max_zone_idx.
> Not insisting, but perhaps max_zoneidx would simply be shorter than
> highest_zoneidx, while saying the same thing?

I think that highest_zoneidx looks more familiar than max_zoneidx since
it is previously high_zoneidx. It would cause less confusion.

> Also I wonder if we still need the accessor ac_classzone_idx() (before rename),
> or just replace it with ac->highest_zoneidx (or whatever the final name is)
> instead of renaming it?

Okay. Looks like we don't need the accessor. I will use open-code.

Thanks.