[tip: x86/misc] selftests/x86/ptrace_syscall_32: Fix no-vDSO segfault

From: tip-bot2 for Andy Lutomirski
Date: Fri Mar 20 2020 - 06:37:04 EST


The following commit has been merged into the x86/misc branch of tip:

Commit-ID: 630b99ab60aa972052a4202a1ff96c7e45eb0054
Gitweb: https://git.kernel.org/tip/630b99ab60aa972052a4202a1ff96c7e45eb0054
Author: Andy Lutomirski <luto@xxxxxxxxxx>
AuthorDate: Thu, 12 Mar 2020 15:35:51 -07:00
Committer: Borislav Petkov <bp@xxxxxxx>
CommitterDate: Fri, 20 Mar 2020 11:28:47 +01:00

selftests/x86/ptrace_syscall_32: Fix no-vDSO segfault

If AT_SYSINFO is not present, don't try to call a NULL pointer.

Reported-by: kbuild test robot <lkp@xxxxxxxxx>
Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>
Signed-off-by: Borislav Petkov <bp@xxxxxxx>
Link: https://lkml.kernel.org/r/faaf688265a7e1a5b944d6f8bc0f6368158306d3.1584052409.git.luto@xxxxxxxxxx
---
tools/testing/selftests/x86/ptrace_syscall.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/x86/ptrace_syscall.c b/tools/testing/selftests/x86/ptrace_syscall.c
index 6f22238..12aaa06 100644
--- a/tools/testing/selftests/x86/ptrace_syscall.c
+++ b/tools/testing/selftests/x86/ptrace_syscall.c
@@ -414,8 +414,12 @@ int main()

#if defined(__i386__) && (!defined(__GLIBC__) || __GLIBC__ > 2 || __GLIBC_MINOR__ >= 16)
vsyscall32 = (void *)getauxval(AT_SYSINFO);
- printf("[RUN]\tCheck AT_SYSINFO return regs\n");
- test_sys32_regs(do_full_vsyscall32);
+ if (vsyscall32) {
+ printf("[RUN]\tCheck AT_SYSINFO return regs\n");
+ test_sys32_regs(do_full_vsyscall32);
+ } else {
+ printf("[SKIP]\tAT_SYSINFO is not available\n");
+ }
#endif

test_ptrace_syscall_restart();