Re: [PATCH v7 00/48] atmel_mxt_ts misc

[Dmitry Osipenko]

Hello Jiada,

20.03.2020 06:37, Wang, Jiada ÐÐÑÐÑ:
> Hello Dmitry
> 
> I have submitted v8 patch-set to address your comments towards v7
> patch-set,
> most of checkpatch warnings and errors have been addressed,
> 
> But I didn't update for following two types of warnings
> since I want to keep consistency with legacy code
> 
> WARNING: DEVICE_ATTR unusual permissions '0600' used
> #290: FILE: drivers/input/touchscreen/atmel_mxt_ts.c:3761:
> +static DEVICE_ATTR(debug_v2_enable, 0600, NULL,

What will happen if you'll use 0644? Will an empty line be returned or
driver will crash?

> WARNING: Consider renaming function(s) 'mxt_debug_notify_show' to
> 'debug_notify_show'
> #292: FILE: drivers/input/touchscreen/atmel_mxt_ts.c:3763:
> +static DEVICE_ATTR(debug_notify, 0444, mxt_debug_notify_show, NULL);

Perhaps this should be fine to ignore, although the prefix is indeed a
bit superfluous.

> please let me know if you have different view on this

Thank you very much, I'll test v8 during the weekend.