Re: [PATCH net] ethtool: fix reference leak in some *_SET handlers

[Florian Fainelli]

On 3/22/2020 1:15 PM, Michal Kubecek wrote:
> Andrew noticed that some handlers for *_SET commands leak a netdev
> reference if required ethtool_ops callbacks do not exist. A simple
> reproducer would be e.g.
> 
>   ip link add veth1 type veth peer name veth2
>   ethtool -s veth1 wol g
>   ip link del veth1
> 
> Make sure dev_put() is called when ethtool_ops check fails.
> 
> Reported-by: Andrew Lunn <andrew@xxxxxxx>
> Signed-off-by: Michal Kubecek <mkubecek@xxxxxxx>

Would not you want a Fixes: tag for this change?

Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
-- 
Florian