Re: [PATCH net-next v6 09/10] net: phy: smsc: use phy_read_poll_timeout() to simplify the code

[Florian Fainelli]

On 3/22/2020 7:56 PM, Dejin Zheng wrote:
> use phy_read_poll_timeout() to replace the poll codes for
> simplify lan87xx_read_status() function.
> 
> it should be add msleep(10) before call phy_read_poll_timeout()
> to keep the code more similar, but it will report that warning, so
> modify it to msleep(20).
> 
> ./scripts/checkpatch.pl
> v5-0009-net-phy-smsc-use-phy_read_poll_timeout-to-simplif.patch
> WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
> #42: FILE: drivers/net/phy/smsc.c:126:
> +		msleep(10);
> 
> Suggested-by: Andrew Lunn <andrew@xxxxxxx>
> Signed-off-by: Dejin Zheng <zhengdejin5@xxxxxxxxx>

Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
-- 
Florian