Re: [PATCH] kunit: add --make_options

[shuah]

On 3/14/20 12:24 AM, Greg Thelen wrote:
> shuah <shuah@xxxxxxxxxx> wrote:
>
> > On 2/28/20 6:53 PM, Nathan Chancellor wrote:
> > > On Wed, Feb 26, 2020 at 10:31:34PM -0800, 'Greg Thelen' via Clang Built Linux wrote:
> > > > The kunit.py utility builds an ARCH=um kernel and then runs it.  Add
> > > > optional --make_options flag to kunit.py allowing for the operator to
> > > > specify extra build options.
> > > >
> > > > This allows use of the clang compiler for kunit:
> > > >     tools/testing/kunit/kunit.py run --defconfig \
> > > >       --make_options CC=clang --make_options HOSTCC=clang
> > > >
> > > > Signed-off-by: Greg Thelen <gthelen@xxxxxxxxxx>
> > >
> > > Reviewed-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> >
> > Please rebase on Linux 5.6-rc5 and resend. I tried applying
> > on Linux 5.6-rc1 as well as 5.6-rc5 and both fail.
> >
> > thanks,
> > -- Shuah
>
> Rebased onto v5.6-rc5 below:
>
> > From 0517b2c8b481535fb52bd86e94be1fec9aaeead7 Mon Sep 17 00:00:00 2001
> From: Greg Thelen <gthelen@xxxxxxxxxx>
> Date: Wed, 26 Feb 2020 22:31:34 -0800
> Subject: [PATCH v2] kunit: add --make_options
>
> The kunit.py utility builds an ARCH=um kernel and then runs it.  Add
> optional --make_options flag to kunit.py allowing for the operator to
> specify extra build options.
>
> This allows use of the clang compiler for kunit:
>    tools/testing/kunit/kunit.py run --defconfig \
>      --make_options CC=clang --make_options HOSTCC=clang
>
> Signed-off-by: Greg Thelen <gthelen@xxxxxxxxxx>

I can't apply this one.

Please send a proper patch with either REBASE tag or v2.

thanks,
-- Shuah