Re: [PATCH V3 2/4] backlight: qcom-wled: Add callback functions

[kgunda]

On 2020-03-11 16:00, Daniel Thompson wrote:
> On Wed, Mar 11, 2020 at 12:11:00PM +0530, kgunda@xxxxxxxxxxxxxx wrote:
> > On 2020-03-10 20:57, Daniel Thompson wrote:
> > > On Mon, Mar 09, 2020 at 06:56:00PM +0530, Kiran Gunda wrote:
> > > > Add cabc_config, sync_toggle, wled_ovp_fault_status and wled_ovp_delay
> > > > callback functions to prepare the driver for adding WLED5 support.
> > > >
> > > > Signed-off-by: Kiran Gunda <kgunda@xxxxxxxxxxxxxx>
> > >
> > > Overall this code would a lot easier to review if
> > > > ---
> > > >  drivers/video/backlight/qcom-wled.c | 196
> > > > +++++++++++++++++++++++-------------
> > > >  1 file changed, 126 insertions(+), 70 deletions(-)
> > > >
> > > > diff --git a/drivers/video/backlight/qcom-wled.c
> > > > b/drivers/video/backlight/qcom-wled.c
> > > > index 3d276b3..b73f273 100644
> > > > --- a/drivers/video/backlight/qcom-wled.c
> > > > +++ b/drivers/video/backlight/qcom-wled.c
> > > > @@ -128,6 +128,7 @@ struct wled_config {
> > > >  	bool cs_out_en;
> > > >  	bool ext_gen;
> > > >  	bool cabc;
> > > > +	bool en_cabc;
> > >
> > > Does this ever get set to true?
> > >
> > Yes. If user wants use the cabc pin to control the brightness and
> > use the "qcom,cabc" DT property in the device tree.
>
> That sounds like what you intended the code to do!
>
> Is the code that does this present in the patch? I could not find
> it.
okay... It's my bad. We already have the "cabc" for this. I will remove 
the en_cabc in
next series.
> Daniel.