Re: [PATCH 0/2] Fix errors when try to build kvm selftests on

[Paolo Bonzini]

On 23/03/20 16:44, shuah wrote:
> On 3/18/20 7:13 AM, Paolo Bonzini wrote:
>> On 15/03/20 10:34, Xiaoyao Li wrote:
>>> I attempted to build KVM selftests on a specified dir, unfortunately
>>> neither    "make O=~/mydir TARGETS=kvm" in tools/testing/selftests, nor
>>> "make OUTPUT=~/mydir" in tools/testing/selftests/kvm work.
>>>
>>> This series aims to make both work.
>>>
>>> Xiaoyao Li (2):
>>>    kvm: selftests: Fix no directory error when OUTPUT specified
> 
> This definitely isn't thr right fix for this issue.
> 
>>>    selftests: export INSTALL_HDR_PATH if using "O" to specify output dir
> 
> Might be okay, but hard to find problems with the limited testing
> done just on the kvm test.
> 
>>>
>>>   tools/testing/selftests/Makefile     | 6 +++++-
>>>   tools/testing/selftests/kvm/Makefile | 3 ++-
>>>   2 files changed, 7 insertions(+), 2 deletions(-)
>>>
>>
>> Queued, thanks.
>>
>> Paolo
>>
>>
> Can you please drop these for your queue. I would like to make sure
> they work with other patches queued in kselftest next and would like
> these go through kselftest tree.
> 
> It will be easier to find regressions when tested with other patches
> to framework as opposed to limited testing on just the kvm test.

Sure, thanks.

Paolo