Re: [PATCH bpf-next v5 5/7] bpf: lsm: Initialize the BPF LSM hooks

From: KP Singh
Date: Mon Mar 23 2020 - 21:53:12 EST


On 23-Mär 15:12, Kees Cook wrote:
> On Mon, Mar 23, 2020 at 02:58:18PM -0700, Casey Schaufler wrote:
> > That's not too terrible, I suppose. What would you be thinking for
> > the calls that do use call_int_hook()?
> >
> > rc = call_int_hook(something, something_default, goodnesses);
> >
> > or embedded in the macro:
> >
> > rc = call_int_hook(something, goodnesses);
>
> Oh yes, good point. The hook call already knows the name, so:
>
> #define call_int_hook(FUNC, ...) ({ \
> int RC = FUNC#_default; \

Excellent ideas, I will spin up the next revision with these changes.

- KP

> ...
>
>
> --
> Kees Cook
>
>