Re: [PATCH 2/2] thermal: core: Remove pointless debug traces

[Lukasz Luba]

Hi Daniel,

On 3/31/20 5:54 PM, Daniel Lezcano wrote:
> The last temperature and the current temperature are show via a
> dev_debug. The line before, those temperature are also traced.
>
> It is pointless to duplicate the traces for the temperatures,
> remove the dev_dbg traces.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> ---
>   drivers/thermal/thermal_core.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 9a321dc548c8..c06550930979 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -447,12 +447,6 @@ static void update_temperature(struct thermal_zone_device *tz)
>   	mutex_unlock(&tz->lock);
>   
>   	trace_thermal_temperature(tz);
> -	if (tz->last_temperature == THERMAL_TEMP_INVALID)
> -		dev_dbg(&tz->device, "last_temperature N/A, current_temperature=%d\n",
> -			tz->temperature);
> -	else
> -		dev_dbg(&tz->device, "last_temperature=%d, current_temperature=%d\n",
> -			tz->last_temperature, tz->temperature);
>   }
>   
>   static void thermal_zone_device_init(struct thermal_zone_device *tz)

This prints really deserve to be removed.

Reviewed-by: Lukasz Luba <lukasz.luba@xxxxxxx>

Regards,
Lukasz