Re: [PATCH] mm, trivial: Simplify swap related code in try_to_unmap_one()

From: Huang\, Ying
Date: Wed Apr 01 2020 - 04:48:33 EST


Michal Hocko <mhocko@xxxxxxxxxx> writes:

> On Wed 01-04-20 09:11:13, Huang, Ying wrote:
> [...]
>> Then what is the check !PageSwapBacked() && PageSwapCache() for? To
>> prevent someone to change the definition of PageSwapCache() in the
>> future to break this?
>
> Yes this is my understading. It is essentially an assert that enforces
> the assumption about swap cache vs. swap backed being coupled.

OK. Then we can just keep the current code.

Best Regards,
Huang, Ying