Re: [PATCH v2 08/16] powerpc/watchpoint: Disable all available watchpoints when !dawr_force_enable

[Ravi Bangoria]

On 4/1/20 12:03 PM, Christophe Leroy wrote:
> Le 01/04/2020 Ã 08:13, Ravi Bangoria a ÃcritÂ:
> > Instead of disabling only first watchpoint, disable all available
> > watchpoints while clearing dawr_force_enable.
>
> Can you also explain why you change the function name ?

Right. I should have. Will add it in next version.

> > Signed-off-by: Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxx>
> > ---
> > Â arch/powerpc/kernel/dawr.c | 10 +++++++---
> > Â 1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/powerpc/kernel/dawr.c b/arch/powerpc/kernel/dawr.c
> > index 311e51ee09f4..5c882f07ac7d 100644
> > --- a/arch/powerpc/kernel/dawr.c
> > +++ b/arch/powerpc/kernel/dawr.c
> > @@ -50,9 +50,13 @@ int set_dawr(struct arch_hw_breakpoint *brk, int nr)
> > ÂÂÂÂÂ return 0;
> > Â }
> > -static void set_dawr_cb(void *info)
> > +static void disable_dawrs(void *info)
>
> Wouldn't it be better to keep _cb at the end of the function ?

Sure.

Ravi