Re: [PATCH V9 1/9] vhost: refine vhost and vringh kconfig

[Jason Wang]

On 2020/4/1 äå10:35, Michael S. Tsirkin wrote:
> > diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig
> > index 2523a1d4290a..362b832f5338 100644
> > --- a/drivers/vhost/Kconfig
> > +++ b/drivers/vhost/Kconfig
> > @@ -11,19 +11,23 @@ config VHOST_RING
> >   	  This option is selected by any driver which needs to access
> >   	  the host side of a virtio ring.
> >   
> > -menuconfig VHOST
> > -	tristate "Host kernel accelerator for virtio (VHOST)"
> > -	depends on EVENTFD
> > +config VHOST
> > +	tristate
> >   	select VHOST_IOTLB
> >   	help
> >   	  This option is selected by any driver which needs to access
> >   	  the core of vhost.
> >   
> > -if VHOST
> > +menuconfig VHOST_MENU
> > +	bool "VHOST drivers"
> > +	default y
> > +
> > +if VHOST_MENU
> Will this not still have the problem with defconfigs? They don't set
> VHOST_MENU ...


Looks not, since it was enabled by default.

I tested this on s390/ppc defconfigs:

# make ARCH=s390 defconfig
*** Default configuration is based on 'defconfig'
#
# No change to .config
#
# grep CONFIG_VHOST .config
CONFIG_VHOST_IOTLB=m
CONFIG_VHOST=m
CONFIG_VHOST_MENU=y
CONFIG_VHOST_NET=m
CONFIG_VHOST_VSOCK=m
# CONFIG_VHOST_VDPA is not set
# CONFIG_VHOST_CROSS_ENDIAN_LEGACY is not set

Thanks