Re: [PATCH] tty/sysrq: Export sysrq_mask()

[Michael Ellerman]

Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
> On Wed, Apr 01, 2020 at 03:49:56PM +0100, Dmitry Safonov wrote:
>> On 4/1/20 3:46 PM, Greg Kroah-Hartman wrote:
>> > On Wed, Apr 01, 2020 at 03:39:04PM +0100, Dmitry Safonov wrote:
>> >> Build fix for serial_core being module:
>> >>   ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!
>> >>
>> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>> >> Cc: Jiri Slaby <jslaby@xxxxxxxx>
>> >> Reported-by: "kernelci.org bot" <bot@xxxxxxxxxxxx>
>> >> Reported-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
>> >> Signed-off-by: Dmitry Safonov <dima@xxxxxxxxxx>
>> >> ---
>> >>  drivers/tty/sysrq.c | 1 +
>> >>  1 file changed, 1 insertion(+)
>> > 
>> > Is this a new problem?  What commit does this fix?
>> 
>> Right, sorry I've managed to forget adding the tag:
>> 
>> Fixes: eaee41727e6d ("sysctl/sysrq: Remove __sysrq_enabled copy")
>> 
>> Maybe also:
>> 
>> Link:
>> https://lore.kernel.org/linux-fsdevel/87tv23tmy1.fsf@xxxxxxxxxxxxxxxxxx/
>
> Thanks, that works.  WIll queue this up after -rc1 is out.

Why wait until after rc1?

It's a build break for a bunch of folks and the fix is obviously correct
(famous last words).

cheers