Re: [PATCH] staging: rtl8712: fix checkpatch warnings

From: Dan Carpenter
Date: Thu Apr 02 2020 - 04:16:20 EST


On Thu, Mar 26, 2020 at 01:56:16AM -0400, Aiman Najjar wrote:
> @@ -350,7 +351,7 @@ static int xmitframe_addmic(struct _adapter *padapter,
> struct sta_info *stainfo;
> struct qos_priv *pqospriv = &(padapter->mlmepriv.qospriv);
> struct pkt_attrib *pattrib = &pxmitframe->attrib;
> - struct security_priv *psecuritypriv = &padapter->securitypriv;
> + struct security_priv *psecpriv = &padapter->securitypriv;

This patch is doing too many things of course, but the other problem is
that when you're renaming variables we don't what them to start with "p"
to mean that they are a pointer. "psecpriv" should just be "secpriv".
That name is still kind of rubbish, but it's not against the rules like
starting with a p for pointer.

regards,
dan carpenter