Re: [PATCH 1/5] ARM: dts: at91: sama5d2_ptc_ek: fix sdmmc0 node description

From: Eugen.Hristev
Date: Thu Apr 02 2020 - 05:20:21 EST


On 02.04.2020 01:15, Ludovic Desroches wrote:
> Remove non-removable and mmc-ddr-1_8v properties from the sdmmc0
> node which come probably from an unchecked copy/paste.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@xxxxxxxxxxxxx>
> Fixes:42ed535595ec "ARM: dts: at91: introduce the sama5d2 ptc ek board"
> Cc: stable@xxxxxxxxxxxxxxx # 4.19 and later
> ---
> arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
> index 1c24ac8019ba7..772809c54c1f3 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
> @@ -125,8 +125,6 @@ sdmmc0: sdio-host@a0000000 {
> bus-width = <8>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_sdmmc0_default>;
> - non-removable;
> - mmc-ddr-1_8v;

Hi Ludovic,

I am not sure about the removal of mmc-ddr-1_8v; this means eMMCs
connected on this slot won't work in high speed mode, some people use
eMMC to SD-Card adapters and stick them into SD-Card slots.
Would it be a problem to keep this property here ?

Thanks,
Eugen

> status = "okay";
> };
>
>