Re: [PATCH][next] net: atlantic: fix missing | operator when assigning rec->llc
From: David Miller
Date: Thu Apr 02 2020 - 09:51:29 EST
From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Thu, 2 Apr 2020 00:27:36 +0100
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> rec->llc is currently being assigned twice, once with the lower 8 bits
> from packed_record[8] and then re-assigned afterwards with data from
> packed_record[9]. This looks like a type, I believe the second assignment
> should be using the |= operator rather than a direct assignment.
>
> Addresses-Coverity: ("Unused value")
> Fixes: b8f8a0b7b5cb ("net: atlantic: MACSec ingress offload HW bindings")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Applied, thanks.