Re: [PATCH net] crypto: chtls - Fix build error without IPV6

[David Miller]

From: YueHaibing <yuehaibing@xxxxxxxxxx>
Date: Thu, 2 Apr 2020 09:43:23 +0800

> If IPV6 is not set, build fails:
> 
> drivers/crypto/chelsio/chcr_ktls.c: In function ʽchcr_ktls_act_open_req6ʼ:
> ./include/net/sock.h:380:37: error: ʽstruct sock_commonʼ has no member named ʽskc_v6_rcv_saddrʼ; did you mean ʽskc_rcv_saddrʼ?
>  #define sk_v6_rcv_saddr __sk_common.skc_v6_rcv_saddr
>                                      ^
> drivers/crypto/chelsio/chcr_ktls.c:258:37: note: in expansion of macro ʽsk_v6_rcv_saddrʼ
>   cpl->local_ip_hi = *(__be64 *)&sk->sk_v6_rcv_saddr.in6_u.u6_addr8[0];
>                                      ^~~~~~~~~~~~~~~
> 
> Add IPV6 dependency to fix this.
> 
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Fixes: 62370a4f346d ("cxgb4/chcr: Add ipv6 support and statistics")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

This is a hard hammer, and I think proper CPP testing should be added to the
driver code instead.