Re: [PATCH 0/6] Fix several issues at qconf.cc
From: Masahiro Yamada
Date: Thu Apr 02 2020 - 12:56:19 EST
On Thu, Apr 2, 2020 at 6:28 PM Mauro Carvalho Chehab
<mchehab+huawei@xxxxxxxxxx> wrote:
>
> Since its conversion to support Qt5, back on Kernel 3.14, the qconf.cc tool
> has been having some issues. With Kernel 5.6 (and Qt 5.13) it doesn't
> work at all, on any of its modes.
>
> This patch series restore its functionality to what it had before Kernel 3.14.
>
> Now, all three modes should work as expected, and the layout will be shown
> with a vertical split, with the help messages at the botton, for both Single and
> Full modes.
>
> The Split mode should also work properly, with its horizontal split showing
> the main config items at the left and a per-items view at the right.
>
> Mauro Carvalho Chehab (6):
> kconfig: qconf: clean deprecated warnings
> kconfig: qconf: Change title for the item window
> kconfig: qconf: fix the content of the main widget
> kconfig: qconf: fix support for the split view mode
> kconfig: qconf: remove some old bogus TODOs
> kconfig: qconf: Fix a few alignment issues
Thank you for fixing several issues!
I will pick this series for v5.7-rc1 soon.
>
> scripts/kconfig/qconf.cc | 90 ++++++++++++++++++++++++++++------------
> scripts/kconfig/qconf.h | 2 +
> 2 files changed, 66 insertions(+), 26 deletions(-)
>
> --
> 2.25.1
>
>
--
Best Regards
Masahiro Yamada