Re: [PATCH v15 7/7] soc: qcom: rpmh-rsc: Allow using free WAKE TCS for active request

[Doug Anderson]

Hi,

On Tue, Mar 31, 2020 at 6:21 AM Maulik Shah <mkshah@xxxxxxxxxxxxxx> wrote:
>
> When there are more than one WAKE TCS available and there is no dedicated
> ACTIVE TCS available, invalidating all WAKE TCSes and waiting for current
> transfer to complete in first WAKE TCS blocks using another free WAKE TCS
> to complete current request.
>
> Remove rpmh_rsc_invalidate() to happen from tcs_write() when WAKE TCSes
> is re-purposed to be used for Active mode. Clear only currently used
> WAKE TCS's register configuration.
>
> Mark the caches as dirty so next time when rpmh_flush() is invoked it
> can invalidate and program cached sleep and wake sets again.

Comment above is no longer right now that you've removed the place
that marks caches as dirty.


> Fixes: 2de4b8d33eab (drivers: qcom: rpmh-rsc: allow active requests from wake TCS)
> Signed-off-by: Maulik Shah <mkshah@xxxxxxxxxxxxxx>
> ---
>  drivers/soc/qcom/rpmh-rsc.c | 23 +++++++++++------------
>  1 file changed, 11 insertions(+), 12 deletions(-)

Other than the comment nit:

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>