Re: [PATCH v8 6/7] tools/perf: Enable Hz/hz prinitg for --metric-only option

From: Andi Kleen
Date: Thu Apr 02 2020 - 16:42:10 EST


> > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> > index 9e757d18d713..679aaa655824 100644
> > --- a/tools/perf/util/stat-display.c
> > +++ b/tools/perf/util/stat-display.c
> > @@ -237,8 +237,6 @@ static bool valid_only_metric(const char *unit)
> > if (!unit)
> > return false;
> > if (strstr(unit, "/sec") ||
> > - strstr(unit, "hz") ||
> > - strstr(unit, "Hz") ||
>
> will this change output of --metric-only for some setups then?
>
> Andi, are you ok with this?

Yes should be ok

$ grep -i ScaleUnit.*hz arch/x86/*/*
$

Probably was for some metric we later dropped.

-Andi