Re: [PATCH][next] mlxsw: spectrum_trap: fix unintention integer overflow on left shift

From: David Miller
Date: Thu Apr 02 2020 - 21:00:23 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Thu, 2 Apr 2020 15:48:51 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Shifting the integer value 1 is evaluated using 32-bit
> arithmetic and then used in an expression that expects a 64-bit
> value, so there is potentially an integer overflow. Fix this
> by using the BIT_ULL macro to perform the shift and avoid the
> overflow.
>
> Addresses-Coverity: ("Unintentional integer overflow")
> Fixes: 13f2e64b94ea ("mlxsw: spectrum_trap: Add devlink-trap policer support")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied, thanks.