Re: [PATCH v3] squashfs: Migrate from ll_rw_block usage to BIO
From: Philippe Liard
Date: Thu Apr 02 2020 - 21:37:31 EST
This is lower priority for us now but I agree that it would be good to land it.
This is my first patch being approved so I'm not familiar with the next steps.
Can you land it yourself or is there something more that I should do?
On Fri, Apr 3, 2020 at 12:35 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> On Fri, Nov 15, 2019 at 10:20:33AM +0900, Philippe Liard wrote:
> > On Wed, Nov 6, 2019 at 6:28 PM Philippe Liard <pliard@xxxxxxxxxx> wrote:
> > >
> > > On Wed, Nov 6, 2019 at 5:37 PM Christoph Hellwig <hch@xxxxxx> wrote:
> > > >
> > > > Sorry for the empty reply.
> > > >
> > > > This was meant to say that the patch looks good to me:
> > > >
> > > > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> > >
> > > Thanks!
> >
> > FYI I'm unfortunately no longer observing the 40% impact announced in the
> > commit description after many optimizations landed in the Chrome OS VM
> > infrastructure.
> >
> > Hopefully moving to BIO is still desirable though. Thank you in any case for
> > your help/guidance and all the time you spent reviewing this.
>
> Do you still plan to submit the patch? I think it is a major cleanup
> of the codebase, so I'd like to see it land.