Re: [PATCH] staging: fsl-dpaa2: ethsw: Fix parenthesis alignment
From: Dan Carpenter
Date: Fri Apr 03 2020 - 04:31:04 EST
On Wed, Apr 01, 2020 at 07:33:10PM -0700, John B. Wyatt IV wrote:
> Fix 2 parenthesis alignment issues.
>
> Reported by checkpatch.
>
> Signed-off-by: John B. Wyatt IV <jbwyatt4@xxxxxxxxx>
> ---
> drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
> index 676d1ad1b50d..546ad376df99 100644
> --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
> +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
> @@ -1094,7 +1094,8 @@ static int swdev_port_obj_del(struct net_device *netdev,
>
> static int
> ethsw_switchdev_port_attr_set_event(struct net_device *netdev,
> - struct switchdev_notifier_port_attr_info *port_attr_info)
> + struct switchdev_notifier_port_attr_info
> + *port_attr_info)
I feel like the end result is worse than the original code because of
how the type and the parameter name are on different lines. Sorry. :/
regards,
dan carpenter