RE: [PATCH v6 02/11] arm64: defconfig: enable CONFIG_PCIE_RCAR_HOST

[Prabhakar Mahadev Lad]

Hi Shimoda-san/Geert-san,

> -----Original Message-----
> From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> Sent: 03 April 2020 10:05
> To: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Cc: Will Deacon <will@xxxxxxxxxx>; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; Catalin Marinas <catalin.marinas@xxxxxxx>; Arnd
> Bergmann <arnd@xxxxxxxx>; Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Andrew Murray <andrew.murray@xxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx; Chris
> Paterson <Chris.Paterson2@xxxxxxxxxxx>; Frank Rowand <frowand.list@xxxxxxxxx>; Gustavo Pimentel
> <gustavo.pimentel@xxxxxxxxxxxx>; Jingoo Han <jingoohan1@xxxxxxxxx>; Simon Horman <horms@xxxxxxxxxxxx>; Shawn Lin
> <shawn.lin@xxxxxxxxxxxxxx>; Tom Joseph <tjoseph@xxxxxxxxxxx>; Heiko Stuebner <heiko@xxxxxxxxx>; linux-
> rockchip@xxxxxxxxxxxxxxxxxxx; Lad Prabhakar <prabhakar.csengg@xxxxxxxxx>; Magnus Damm <magnus.damm@xxxxxxxxx>; Kishon Vijay
> Abraham I <kishon@xxxxxx>; Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>; Marek Vasut <marek.vasut+renesas@xxxxxxxxx>; linux-
> pci@xxxxxxxxxxxxxxx; Bjorn Helgaas <bhelgaas@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland
> <mark.rutland@xxxxxxx>
> Subject: RE: [PATCH v6 02/11] arm64: defconfig: enable CONFIG_PCIE_RCAR_HOST
>
> Hi Geert-san,
>
> Thank you for your comments!
>
> > From: Geert Uytterhoeven, Sent: Friday, April 3, 2020 5:28 PM
> <snip>
> > > But, I'm thinking this patch (and patch 03/11) should be separated
> > > from this patch series for arm64 subsystem to ease maintenance.
> > > My scenario is:
> > >  1) patch series 1: R-Car PCIe endpoint support.
> > >  -- This means: patch 1, 4 - 9, 11
> > >
> > >  2) After the patch series 1 is merged, submit this patch 2/11 to arm subsystem
> > >    and submit the patch 10/11 to misc subsystem.
> > >
> > >  3) At last, submit patch 3/11 after the patch 2/11 is merged.
> > >
> > > Geert-san, what do you think?
> >
> > Thanks, I agree with your summary.
> >
> > I can take patch 2/11 through renesas-devel.
> > Probably it's best if I submit it to arm-soc as a fix for v5.8, after
> > the driver part
> > has been merged into v5.8-rc1, so 3/11 can be submitted for v5.9.
>
> Thank you! I got it.
>
Thank you, Ill split the patches accordingly and post a v7.

> > BTW, I'm wondering about "[PATCH v6 05/11] PCI: rcar: Fix calculating
> > mask for PCIEPAMR register". Can the issue fixed by this patch happen with
> > the current driver in host mode, or is that limited to ep mode?
> > In case of the former, please submit it to the PCI maintainer as a separate
> > fix.
>
> Thank you for pointed it out. I think this is the case of the former.
> IIUC, if such a small window PCIe device exists, the issue happens.
>
> Prabhakar-san, is my understanding correct?
>
This issue will only be hit on EP, when in host mode the sizes will be fixed to 1 Mbytes /2 Mbytes /128 Mbytes

Cheers,
--Prabhakar

> Best regards,
> Yoshihiro Shimoda



Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647