Re: AMD DC graphics display code enables -mhard-float, -msse, -msse2 without any visible FPU state protection

From: Masami Hiramatsu
Date: Sat Apr 04 2020 - 04:33:24 EST


On Fri, 3 Apr 2020 20:15:11 -0700
Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:

> On 4/3/20 8:08 PM, Masami Hiramatsu wrote:
> > +static inline int insn_is_fpu(struct insn *insn)
> > +{
> > + if (!insn->opcode.got)
> > + insn_get_opcode(insn);
> > + if (inat_is_fpu(insn->attr)) {
> > + if (insn->attr & INAT_FPUIFVEX)
> > + return insn_is_avx(insn);
> > + return 1;
> > + }
>
> return 0; // ??

Oops, right!

Hm, I need to add a caller for this API...

Thanks,

>
> > +}
> > +
>
>
> --
> ~Randy
>


--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>