Re: [PATCH] usb: host: u132-hcd: Remove u132_static_list and list head u132_list

[Madhuparna Bhowmik]

On Sat, Apr 04, 2020 at 11:23:08AM +0200, Greg KH wrote:
> On Fri, Apr 03, 2020 at 11:48:16PM +0530, madhuparnabhowmik10@xxxxxxxxx wrote:
> > From: Madhuparna Bhowmik <madhuparnabhowmik10@xxxxxxxxx>
> > 
> > u132_static_list is a global list protected by u132_module_lock.
> > It is read in the u132_hcd_exit() function without holding the lock
> > thus may lead to data race.
> > However, it turns out that this list isn't used for anything useful
> > and thus it is okay to get rid of it.
> > Thus, remove the u132_static_list from u132-hcd module.
> > Also remove struct list_head u132_list from struct u132.
> > 
> > Found by Linux Driver Verification project (linuxtesting.org).
> > 
> > Suggested-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@xxxxxxxxx>
> > ---
> >  drivers/usb/host/u132-hcd.c | 10 ----------
> >  1 file changed, 10 deletions(-)
> 
> Please properly version your patches, otherwise I have no idea what
> changed from the previous one, nor do I know which patch to take over
> which.
> 
> The instructions for how to do this is in the documentation.  Please fix
> up and resend so I have a chance to know what to do...
>
Sure, I will do it.

Thank you,
Madhuparna
> thanks,
> 
> greg k-h